Yes his suicide run means nothing because he didn’t make the choice to stop it. Rose could’ve delivered her (awful) speech about love over comms and actually make him wrestle with the choice for a moment before pulling out. But instead the choice is literally forced on him by Rose, robbing him of any arc or self-realisation.
Add to the fact that literally nothing is done with his ex-stormtrooper past across two whole films (aside from conveniently giving him exposition) when instead it could be fertile ground for conflict, inner turmoil and suspicion amongst other characters, he is a total waste of an interesting character premise.
I guess that’s why you receptionists get paid the big bucks!